lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231223182213.GK201037@kernel.org> Date: Sat, 23 Dec 2023 18:22:13 +0000 From: Simon Horman <horms@...nel.org> To: Karol Kolacinski <karol.kolacinski@...el.com> Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, anthony.l.nguyen@...el.com, jesse.brandeburg@...el.com, Jacob Keller <jacob.e.keller@...el.com> Subject: Re: [PATCH v4 iwl-next 2/6] ice: pass reset type to PTP reset functions On Thu, Dec 21, 2023 at 11:03:22AM +0100, Karol Kolacinski wrote: > From: Jacob Keller <jacob.e.keller@...el.com> > > The ice_ptp_prepare_for_reset() and ice_ptp_reset() functions currently > check the pf->flags ICE_FLAG_PFR_REQ bit to determine if the current > reset is a PF reset or not. > > This is problematic, because it is possible that a PF reset and a higher > level reset (CORE reset, GLOBAL reset, EMP reset) are requested > simultaneously. In that case, the driver performs the highest level > reset requested. However, the ICE_FLAG_PFR_REQ flag will still be set. > > The main driver reset functions take an enum ice_reset_req indicating > which reset is actually being performed. Pass this data into the PTP > functions and rely on this instead of relying on the driver flags. > > This ensures that the PTP code performs the proper level of reset that > the driver is actually undergoing. > > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> > Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com> > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com> ... > diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/ethernet/intel/ice/ice_ptp.h > index 2457380142e1..bbac053bd099 100644 > --- a/drivers/net/ethernet/intel/ice/ice_ptp.h > +++ b/drivers/net/ethernet/intel/ice/ice_ptp.h > @@ -314,8 +314,8 @@ enum ice_tx_tstamp_work ice_ptp_process_ts(struct ice_pf *pf); > > u64 ice_ptp_get_rx_hwts(const union ice_32b_rx_flex_desc *rx_desc, > const struct ice_pkt_ctx *pkt_ctx); > -void ice_ptp_reset(struct ice_pf *pf); Hi Karol and Jacob, I think that the declaration of ice_ptp_reset() is needed for the case where CONFIG_PTP_1588_CLOCK=y until patch 5/6 of this series. > -void ice_ptp_prepare_for_reset(struct ice_pf *pf); > +void ice_ptp_prepare_for_reset(struct ice_pf *pf, > + enum ice_reset_req reset_type); > void ice_ptp_init(struct ice_pf *pf); > void ice_ptp_release(struct ice_pf *pf); > void ice_ptp_link_change(struct ice_pf *pf, u8 port, bool linkup); ...
Powered by blists - more mailing lists