lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <96e4933c-a2aa-4401-a440-c11f1e95b891@linux.intel.com> Date: Tue, 26 Dec 2023 12:49:05 +0200 From: "naamax.meir" <naamax.meir@...ux.intel.com> To: Kurt Kanzenbach <kurt@...utronix.de>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Vinicius Costa Gomes <vinicius.gomes@...el.com> Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, intel-wired-lan@...ts.osuosl.org, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] igc: Check VLAN TCI mask On 12/1/2023 09:50, Kurt Kanzenbach wrote: > Currently the driver accepts VLAN TCI steering rules regardless of the > configured mask. And things might fail silently or with confusing error > messages to the user. > > There are two ways to handle the VLAN TCI mask: > > 1. Match on the PCP field using a VLAN prio filter > 2. Match on complete TCI field using a flex filter > > Therefore, add checks and code for that. > > For instance the following rule is invalid and will be converted into a > VLAN prio rule which is not correct: > |root@...t:~# ethtool -N enp3s0 flow-type ether vlan 0x0001 m 0xf000 \ > | action 1 > |Added rule with ID 61 > |root@...t:~# ethtool --show-ntuple enp3s0 > |4 RX rings available > |Total 1 rules > | > |Filter: 61 > | Flow Type: Raw Ethernet > | Src MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF > | Dest MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF > | Ethertype: 0x0 mask: 0xFFFF > | VLAN EtherType: 0x0 mask: 0xffff > | VLAN: 0x1 mask: 0x1fff > | User-defined: 0x0 mask: 0xffffffffffffffff > | Action: Direct to queue 1 > > After: > |root@...t:~# ethtool -N enp3s0 flow-type ether vlan 0x0001 m 0xf000 \ > | action 1 > |rmgr: Cannot insert RX class rule: Operation not supported > > Fixes: 7991487ecb2d ("igc: Allow for Flex Filters to be installed") > Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de> > Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com> > --- > drivers/net/ethernet/intel/igc/igc.h | 1 + > drivers/net/ethernet/intel/igc/igc_ethtool.c | 28 +++++++++++++++++--- > 2 files changed, 26 insertions(+), 3 deletions(-) Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
Powered by blists - more mailing lists