netdev - Re: [PATCH v2] net: wwan: t7xx: Add fastboot interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi9TLiKgtPrE=XLnn694mkScj=aASN7Kc8-Qu-hKGXR0Lg@mail.gmail.com>
Date: Tue, 26 Dec 2023 12:09:59 +0100
From: Loic Poulain <loic.poulain@...aro.org>
To: Jinjian Song <songjinjian@...mail.com>
Cc: netdev@...r.kernel.org, chandrashekar.devegowda@...el.com, 
	chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com, 
	m.chetan.kumar@...ux.intel.com, ricardo.martinez@...ux.intel.com, 
	ryazanov.s.a@...il.com, johannes@...solutions.net, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	linux-kernel@...r.kernel.com, vsankar@...ovo.com, danielwinkler@...gle.com, 
	nmarupaka@...gle.com, joey.zhao@...ocom.com, liuqf@...ocom.com, 
	felix.yan@...ocom.com, Jinjian Song <jinjian.song@...ocom.com>
Subject: Re: [PATCH v2] net: wwan: t7xx: Add fastboot interface

Hello Jinjian,

On Tue, 26 Dec 2023 at 08:16, Jinjian Song <songjinjian@...mail.com> wrote:
>
> From: Jinjian Song <jinjian.song@...ocom.com>
>
> To support cases such as firmware update or core dump, the t7xx
> device is capable of signaling the host that a special port needs
> to be created before the handshake phase.
>
> Adds the infrastructure required to create the early ports which
> also requires a different configuration of CLDMA queues.
>
> On early detection of wwan device in fastboot mode, driver sets
> up CLDMA0 HW tx/rx queues for raw data transfer and then create
> fastboot port to user space.

Could you please split this single commit int a proper series. At
least one dedicated commit for adding new port to the core, and you
may want one for the new sysfs attributes and state machine, then one
for  your driver fastboot port support...


>
> Signed-off-by: Jinjian Song <jinjian.song@...ocom.com>
> ---
> v2:
>  * optimizing using goto label in t7xx_pci_probe
> ---
>  drivers/net/wwan/t7xx/Makefile             |   1 +
>  drivers/net/wwan/t7xx/t7xx_hif_cldma.c     |  47 +++++--
>  drivers/net/wwan/t7xx/t7xx_hif_cldma.h     |  18 ++-
>  drivers/net/wwan/t7xx/t7xx_modem_ops.c     |   5 +-
>  drivers/net/wwan/t7xx/t7xx_pci.c           |  88 +++++++++++-
>  drivers/net/wwan/t7xx/t7xx_pci.h           |  11 ++
>  drivers/net/wwan/t7xx/t7xx_port.h          |   4 +
>  drivers/net/wwan/t7xx/t7xx_port_fastboot.c | 155 +++++++++++++++++++++
>  drivers/net/wwan/t7xx/t7xx_port_proxy.c    |  89 ++++++++++--
>  drivers/net/wwan/t7xx/t7xx_port_proxy.h    |  12 ++
>  drivers/net/wwan/t7xx/t7xx_port_wwan.c     |   5 +-
>  drivers/net/wwan/t7xx/t7xx_reg.h           |  28 +++-
>  drivers/net/wwan/t7xx/t7xx_state_monitor.c | 125 ++++++++++++++---
>  drivers/net/wwan/t7xx/t7xx_state_monitor.h |   1 +
>  drivers/net/wwan/wwan_core.c               |   4 +
>  include/linux/wwan.h                       |   2 +
>  16 files changed, 537 insertions(+), 58 deletions(-)
>  create mode 100644 drivers/net/wwan/t7xx/t7xx_port_fastboot.c