netdev - Re: [PATCH v2 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Dec 2023 15:09:57 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Asmaa Mnebhi <asmaa@...dia.com>, Florian Fainelli <f.fainelli@...il.com>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "marek.mojik@....cz" <marek.mojik@....cz>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: David Thompson <davthompson@...dia.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] net: phy: micrel: Add workaround for incomplete
 autonegotiation

On 28.12.2023 14:37, Asmaa Mnebhi wrote:
>  > On 12/28/2023 12:16 AM, Asmaa Mnebhi wrote:
>>> Very rarely, the KSZ9031 fails to complete autonegotiation although it
>>> was initiated via phy_start(). As a result, the link stays down.
>>> Restarting autonegotiation when in this state solves the issue.
>>>
>>> Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>
>>
>> Is there a Micrel errata associated with this work around that could be
>> referenced here?
> 
> Hi Florian,
> 
> No there isn’t. This is based on observations and comparison with the behavior and testing of other PHYs. For example, we don’t see this issue with the Vitesse PHY.
> 
The Microchip KSZ9031 errata documentation lists few link-related errata.
May any of these be relevant in your case? If not, please check with Microchip.
KSZ9031 isn't new, and most likely we would have seen such reports before,
if there's an actual issue.
I'd like to avoid that we add code to work around an issue that is specific
to your setup.

> Thanks.
> Asmaa