netdev - Re: [PATCH net-next v8 1/5] net/sched: Introduce tc block netdev tracking infra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc188893-3d49-4d02-84ad-a85ea399cc92@mojatatu.com>
Date: Thu, 28 Dec 2023 11:13:03 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Jamal Hadi Salim <jhs@...atatu.com>, Ido Schimmel <idosch@...sch.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 mleitner@...hat.com, vladbu@...dia.com, paulb@...dia.com,
 pctammela@...atatu.com, netdev@...r.kernel.org, kernel@...atatu.com
Subject: Re: [PATCH net-next v8 1/5] net/sched: Introduce tc block netdev
 tracking infra

On 28/12/2023 09:35, Jamal Hadi Salim wrote:
> On Thu, Dec 28, 2023 at 6:50 AM Ido Schimmel <idosch@...sch.org> wrote:
>>
>> On Tue, Dec 19, 2023 at 03:16:19PM -0300, Victor Nogueira wrote:
>>> +static int qdisc_block_add_dev(struct Qdisc *sch, struct net_device *dev,
>>> +                            struct netlink_ext_ack *extack)
>>> +{
>>> +     const struct Qdisc_class_ops *cl_ops = sch->ops->cl_ops;
>>> +     struct tcf_block *block;
>>> +     int err;
>>> +
>>> +     block = cl_ops->tcf_block(sch, TC_H_MIN_INGRESS, NULL);
>>
>> Another problem, shouldn't there be a check that these operations are
>> actually implemented? The following now crashes with a NULL pointer
>> dereference:
>>
>> # tc qdisc replace dev swp1 root handle 1: tbf rate 1Mbit burst 256k limit 1M
> 
> 
> I think this broke from v7->v8. Thanks for catching this. We'll send a
> fix shortly.

Just sent a fix to net-next because the original patch hasn't been
propagated to net yet.

cheers,
Victor