netdev - Re: [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240104203527.GM31813@kernel.org>
Date: Thu, 4 Jan 2024 20:35:27 +0000
From: Simon Horman <horms@...nel.org>
To: Jan Sokolowski <jan.sokolowski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Aniruddha Paul <aniruddha.paul@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Jan Glaza <jan.glaza@...el.com>
Subject: Re: [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors

On Wed, Jan 03, 2024 at 03:11:15PM +0100, Jan Sokolowski wrote:
> From: Aniruddha Paul <aniruddha.paul@...el.com>
> 
> HW incorrectly reports EIPE errors on encapsulated packets
> with L2 padding inside inner packet. HW shows outer UDP/IPV4
> packet checksum errors as part of the EIPE flags of the
> Rx descriptor. These are reported only if checksum offload
> is enabled and L3/L4 parsed flag is valid in Rx descriptor.
> 
> When that error is reported by HW, we don't act on it
> instead of incrementing main Rx errors statistic as it
> would normally happen.
> 
> Add a new statistic to count these errors since we still want
> to print them.
> 
> Signed-off-by: Aniruddha Paul <aniruddha.paul@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Jan Glaza <jan.glaza@...el.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>