netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CYYPR11MB842918A887D780F8FCB805FBBD6B2@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Mon, 8 Jan 2024 04:40:37 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Sokolowski, Jan" <jan.sokolowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Sokolowski, Jan"
	<jan.sokolowski@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Glaza, Jan" <jan.glaza@...el.com>,
	"Aniruddha Paul" <aniruddha.paul@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for
 Rx EIPE errors

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jan Sokolowski
> Sent: Wednesday, January 3, 2024 7:41 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Sokolowski, Jan <jan.sokolowski@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Glaza, Jan <jan.glaza@...el.com>; Aniruddha Paul <aniruddha.paul@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: Add a new counter for Rx EIPE errors
>
> From: Aniruddha Paul <aniruddha.paul@...el.com>
>
> HW incorrectly reports EIPE errors on encapsulated packets
> with L2 padding inside inner packet. HW shows outer UDP/IPV4
> packet checksum errors as part of the EIPE flags of the
> Rx descriptor. These are reported only if checksum offload
> is enabled and L3/L4 parsed flag is valid in Rx descriptor.
>
> When that error is reported by HW, we don't act on it
> instead of incrementing main Rx errors statistic as it
> would normally happen.
>
> Add a new statistic to count these errors since we still want
> to print them.
>
> Signed-off-by: Aniruddha Paul <aniruddha.paul@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Jan Glaza <jan.glaza@...el.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice.h          | 1 +
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 1 +
>  drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 8 ++++++--
>  3 files changed, 8 insertions(+), 2 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)