netdev - Re: [PATCH net-next] r8169: fix building with CONFIG_LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1e1a09d9-6617-4612-ac56-ec18a01df902@app.fastmail.com>
Date: Thu, 04 Jan 2024 22:24:11 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Heiner Kallweit" <hkallweit1@...il.com>,
 "Realtek linux nic maintainers" <nic_swsd@...ltek.com>,
 "Paolo Abeni" <pabeni@...hat.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>
Cc: Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: fix building with CONFIG_LEDS_CLASS=m

On Wed, Jan 3, 2024, at 16:52, Heiner Kallweit wrote:
> When r8169 is built-in but LED support is a loadable module, the new
> code to drive the LED causes a link failure:
>
> ld: drivers/net/ethernet/realtek/r8169_leds.o: in function 
> `rtl8168_init_leds':
> r8169_leds.c:(.text+0x36c): undefined reference to 
> `devm_led_classdev_register_ext'
>
> LED support is an optional feature, so fix this issue by adding a Kconfig
> symbol R8169_LEDS that is guaranteed to be false if r8169 is built-in
> and LED core support is a module. As a positive side effect of this change
> r8169_leds.o no longer is built under this configuration.
>
> Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202312281159.9TPeXbNd-lkp@intel.com/
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

This has survived a day of randconfig builds

Tested-by: Arnd Bergmann <arnd@...db.de>