netdev - [PATCHv3 net-next 0/3] add ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240104212431.3275688-1-maheshb@google.com>
Date: Thu,  4 Jan 2024 13:24:31 -0800
From: Mahesh Bandewar <maheshb@...gle.com>
To: Netdev <netdev@...r.kernel.org>, Linux <linux-kernel@...r.kernel.org>, 
	David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Cc: Jonathan Corbet <corbet@....net>, John Stultz <jstultz@...gle.com>, Don Hatchett <hatch@...gle.com>, 
	Yuliang Li <yuliangli@...gle.com>, Mahesh Bandewar <mahesh@...dewar.net>, 
	Mahesh Bandewar <maheshb@...gle.com>, Richard Cochran <richardcochran@...il.com>, 
	Willem de Bruijn <willemb@...gle.com>
Subject: [PATCHv3 net-next 0/3] add ptp_gettimex64any() API

Applications that are very sensitive to time precision
always measure the latency of the PHC (hardware clock) read.
The best suited API for this is getcrosststamp(), however,
not all platforms can architecturally support it, hence
sandwich-ts APIs become more important for these categories
of applications.  The purpose of the sandwich API is to
measure the width of the PHC-read syscall. The current API
that reads PHC supports only one timebase for it (CLOCK_REALTIME).
CLOCK_REALTIME is disciplined by NTP or NTP-like service,
and hence the value is subject to change. This makes some
applications want the sandwich TS to be delivered in other
timebases.

Ideally, there should be only one API that delivers the
PHC-read with the sandwich-TS of the timebase given by the
user, but modifying the existing API (gettimex64) would
break compatibility.

This series implements an API similar to gettimex64() with
a parameter that allows the user to choose the timebase
needed for these sandwich timestamps.

About the name: This is a superset of the current gettimex64().
Since the timebase for gettimex64 is fixed and is only
sys-time (CLOCK_REALTIME), I'm appending 'any' to add the
choice factor. So gettimex64any() would give you eXtended
time with sandwich TS of a timebase of your choice. If there
is a better name, I won't mind changing.

The timebase options are:
   CLOCK_REALTIME, CLOCK_MONOTONIC, and CLOCK_MONOTONIC_RAW

The CLOCK_REALTIME option is equivalent to using the current
gettimex64() method.

The first patch adds this new PTP method, while the second
patch adds the ioctl support for this PTP method. The last
patch in the series updates the selftest to exercise this
new API.

Mahesh Bandewar (3):
  ptp: add new method ptp_gettimex64any()
  ptp: add ioctl interface for ptp_gettimex64any()
  selftest/ptp: extend test to include ptp_gettimex64any()

 drivers/ptp/ptp_chardev.c             | 37 +++++++++++
 include/linux/ptp_clock_kernel.h      | 50 +++++++++++++-
 include/uapi/linux/ptp_clock.h        | 14 ++++
 tools/testing/selftests/ptp/testptp.c | 96 ++++++++++++++++++++++++++-
 4 files changed, 193 insertions(+), 4 deletions(-)

Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
CC: Richard Cochran <richardcochran@...il.com>
CC: "David S. Miller" <davem@...emloft.net>
CC: John Stultz <jstultz@...gle.com>
CC: Jakub Kicinski <kuba@...nel.org>
CC: "Willem de Bruijn" <willemb@...gle.com>
CC: netdev@...r.kernel.org
-- 
2.43.0.195.gebba966016-goog