netdev - Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3e38ed8-e8eb-c079-3f3d-81455cf96db2@huawei.com>
Date: Wed, 10 Jan 2024 17:46:03 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Ilias Apalodimas <ilias.apalodimas@...aro.org>, Jakub Kicinski
	<kuba@...nel.org>
CC: <netdev@...r.kernel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias

On 2024/1/9 15:02, Ilias Apalodimas wrote:
> Hi Jakub,
> 
> On Wed, 3 Jan 2024 at 01:35, Jakub Kicinski <kuba@...nel.org> wrote:
>>
>> On Wed, 20 Dec 2023 10:01:46 +0200 Ilias Apalodimas wrote:
>>> -     long frag_users;
>>> +     long pagecnt_bias;
>>
>> IDK :(
>>
>> pagecnt to mean suggests this is related to page refcount,
>> not page pool specific refcount.
>>
>> More importantly bias is the large number by which we increment.
>> This counter counts how many of the bias references we actually
>> consumed. So how about bias_consumed? bias_used? bias_issued?
>> frags_alloced?
> 
> I had similar concerns, that's why v1 used 'frag_cnt'.
> I am fine with either frags_alloced or frag_cnt

I would suggest that we stick with the *_bias version, and invert the
logic of draining, so that:
1. Aovid one subtraction operation in the data path.
2. Align with other frag implementation.

I guess I can do the above if that is ok with Ilias.

> 
> Thanks
> /Ilias
> .
>