netdev - Re: [PATCH net] af_unix: Avoid a wakeup if data has been not arrived

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iK+tOVB=9TDAP57+C5O6bo5=1Xfd5rgxp6oB86StgmT3g@mail.gmail.com>
Date: Wed, 10 Jan 2024 11:05:06 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Bin Zhong <zhongbin@...edance.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, kuniyu@...zon.com, 
	alexander@...alicyn.com, dhowells@...hat.com, john.fastabend@...il.com, 
	daan.j.demeyer@...il.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, liubo.0617@...edance.com, 
	zhangjinshan.smile@...edance.com
Subject: Re: [PATCH net] af_unix: Avoid a wakeup if data has been not arrived

On Wed, Jan 10, 2024 at 9:47 AM Bin Zhong <zhongbin@...edance.com> wrote:
>
> In the following scenarios, unnecessary wake-up may occur.
> When a thread sends a piece of data and then immediately
> calls recv to wait for the server's data, the server, upon
> receiving this thread's data, calls back unix_write_space
> to wake up this thread.
>
> Therefore, add the filtering conditions of EPOLLIN and
> EPOLLERR in the callback function of the waiting queue in
> the unix_stream_data_wait function to reduce unnecessary
> wake-ups.

This is net-next material, and net-next is currently closed.

Also, I would rather re-use receiver_wake_function(), no need to copy paste it.

Thanks !