[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <afb2cc4d-efcd-4d99-ac78-a65ffa148c74@linaro.org>
Date: Thu, 11 Jan 2024 17:43:54 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jie Luo <quic_luoj@...cinc.com>, Andrew Lunn <andrew@...n.ch>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
quic_kkumarcs@...cinc.com, quic_suruchia@...cinc.com, quic_soni@...cinc.com,
quic_pavir@...cinc.com, quic_souravp@...cinc.com, quic_linchen@...cinc.com,
quic_leiwei@...cinc.com
Subject: Re: [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree
On 11/01/2024 16:59, Jie Luo wrote:
>>> + mux_1 {
>>> + pins = "gpio28";
>>> + function = "mdio1";
>>> + drive-strength = <8>;
>>> + bias-pull-up;
>>> + };
>>
>> I don't know why i'm asking this, because i don't really expect a
>> usable answer. What sort of MUX is this? Should you be using one of
>> the muxes in drivers/net/mdio/mdio-mux-* or something similar?
>>
>> Andrew
>
> Sorry for the confusion, the pin nodes are for the MDIO and MDC, these
> PINs are used by the dedicated hardware MDIO block in the SoC. I will
> update the node name from mux_0 to MDC, mux_1 to MDIO, to make it clear.
> The driver for this node is drivers/net/mdio/mdio-ipq4019.c, it is not
> related to the mdio-mux-* code.
NAK. Run dtbs_check tests on your DTS first.
Best regards,
Krzysztof
Powered by blists - more mailing lists