[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<BJSPR01MB05957755EEAE00C9B853927D9E68A@BJSPR01MB0595.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 11 Jan 2024 10:00:54 +0000
From: ChunHau Tan <chunhau.tan@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "David S . Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
<robh+dt@...nel.org>, Emil Renner Berthing <kernel@...il.dk>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Maxime Coquelin
<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
Simon Horman <horms@...nel.org>, Bartosz Golaszewski
<bartosz.golaszewski@...aro.org>, Andrew Halaney <ahalaney@...hat.com>,
Jisheng Zhang <jszhang@...nel.org>, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Russell King <rmk+kernel@...linux.org.uk>
CC: Leyfoon Tan <leyfoon.tan@...rfivetech.com>, JeeHeng Sia
<jeeheng.sia@...rfivetech.com>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-riscv@...ts.infradead.org"
<linux-riscv@...ts.infradead.org>
Subject: RE: [PATCH v2 0/1] Add StarFive JH8100 dwmac support
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Thursday, 11 January, 2024 4:03 PM
> To: ChunHau Tan <chunhau.tan@...rfivetech.com>; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob Herring
> <robh+dt@...nel.org>; Emil Renner Berthing <kernel@...il.dk>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>;
> Conor Dooley <conor+dt@...nel.org>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; Simon Horman <horms@...nel.org>; Bartosz
> Golaszewski <bartosz.golaszewski@...aro.org>; Andrew Halaney
> <ahalaney@...hat.com>; Jisheng Zhang <jszhang@...nel.org>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Russell King
> <rmk+kernel@...linux.org.uk>
> Cc: Leyfoon Tan <leyfoon.tan@...rfivetech.com>; JeeHeng Sia
> <jeeheng.sia@...rfivetech.com>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-stm32@...md-mailman.stormreply.com;
> linux-arm-kernel@...ts.infradead.org; linux-riscv@...ts.infradead.org
> Subject: Re: [PATCH v2 0/1] Add StarFive JH8100 dwmac support
>
> On 11/01/2024 09:02, Krzysztof Kozlowski wrote:
> > On 11/01/2024 03:55, Tan Chun Hau wrote:
> >> Add StarFive JH8100 dwmac support.
> >> JH8100 dwmac has one reset signal instead of 2 resets as in JH7110.
> >>
> >> Changes in v2:
> >> - Drop driver patch.
> >
> > ? But devices are not compatible, so how can it work?
>
> Wait, your select confused me... later you made them compatible.
Sorry for confusing, let me try to explain in detail,
For JH7110, there are two resets (stmmaceth & ahb)
For JH8100, there are only a resets (stmmaceth)
And both are using same driver code (dwmac-starfive.c), and
in the driver code acknowledges { .compatible = "starfive,jh7110-dwmac" }
In v2 patch, I try to make amend the yaml file by adding "starfive,jh8100-dwmac"
and provide info regarding the differences in resets.
For loading the driver for JH8110,
Will including "starfive,jh7110-dwmac" in device tree file,
please refer to below example of JH7110 & JH8100 device tree file:
Example of JH7110:
gmac0: ethernet@...30000 {
compatible = "starfive,jh7110-dwmac", "snps,dwmac-5.20";
resets = <&aoncrg JH7110_AONRST_GMAC0_AXI>,
<&aoncrg JH7110_AONRST_GMAC0_AHB>;
reset-names = "stmmaceth", "ahb";
};
Example of JH8100:
gmac0: ethernet@...30000 {
compatible = "starfive,jh8100-dwmac", "starfive,jh7110-dwmac","snps,dwmac-5.20";
resets = <&aoncrg JH8100RST_GMAC0>,
reset-names = "stmmaceth";
};
Please share with me if you have any suggestions, thank you.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists