netdev - Re: [PATCH] net: tcp: accept old ack during closing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3YHYoLpDsJ1qx3p74eqGPV-CY8sOqxnX+VvzL8SegD_AQ@mail.gmail.com>
Date: Thu, 11 Jan 2024 18:06:40 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, dsahern@...nel.org, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tcp: accept old ack during closing

On Wed, Jan 10, 2024 at 6:41 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Wed, Jan 10, 2024 at 11:25 AM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > On Wed, Jan 10, 2024 at 4:08 AM Menglong Dong <menglong8.dong@...il.com> wrote:
> > >
> >
> > >
> > > Oops, It should be "SKB_DR_SET(reason, NOT_SPECIFIED);" here.
> > > Sorry that I shouldn't be too confident to compile it.
> > >
> >
> > net-next is closed, come back in ~two weeks, thanks.

Okay, I'll send the V2 after two weeks.

>
> Also look at commit d0e1a1b5a833b625c ("tcp: better validation of
> received ack sequences"), for some context.

Yeah, I already analyzed this commit before. I think that the return
value of tcp_ack() mean different thing to SYN_SEND and FIN_WAIT1
if it is zero, and should be handled separately.

Anyway, we can discuss this part when the net-next is opened.

Thanks!
Menglong Dong