netdev - Re: [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 10:53:36 -0800 (PST)
From: Mat Martineau <martineau@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, Matthieu Baerts <matttbe@...nel.org>, 
    Geliang Tang <geliang.tang@...ux.dev>, Florian Westphal <fw@...len.de>, 
    netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP_JOIN
 option

On Thu, 11 Jan 2024, Eric Dumazet wrote:

> Based on a syzbot report (see 4th patch in the series).
>
> We need to be more explicit about which one of the
> following flag is set by mptcp_parse_option():
>
> - OPTION_MPTCP_MPJ_SYN
> - OPTION_MPTCP_MPJ_SYNACK
> - OPTION_MPTCP_MPJ_ACK
>
> Then select the appropriate values instead of OPTIONS_MPTCP_MPJ
>
> Paolo suggested to do the same for OPTIONS_MPTCP_MPC (5th patch)
>
> Eric Dumazet (5):
>  mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOIN
>  mptcp: strict validation before using mp_opt->hmac
>  mptcp: use OPTION_MPTCP_MPJ_SYNACK in subflow_finish_connect()
>  mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req()
>  mptcp: refine opt_mp_capable determination
>
> net/mptcp/options.c |  6 +++---
> net/mptcp/subflow.c | 16 ++++++++--------
> 2 files changed, 11 insertions(+), 11 deletions(-)

Hi Eric -

Thanks for the fixes, code looks good (one separate commit message 
comment on patch 5):

Reviewed-by: Mat Martineau <martineau@...nel.org>