netdev - Re: [PATCH iproute2] Revert "ss: prevent "Process" column from being printed unless requested"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <694cc41a-59fd-4b13-a6fe-59782beef373@kernel.org>
Date: Mon, 15 Jan 2024 12:27:23 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>,
 Quentin Deslandes <qde@...cy.de>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] Revert "ss: prevent "Process" column from being
 printed unless requested"

Hi Stephen,

On 13/01/2024 17:54, Stephen Hemminger wrote:
> This reverts commit 1607bf531fd2f984438d227ea97312df80e7cf56.
> 
> This commit is being reverted because it breaks output of tcp info.

Thank you for having reverted this commit to solve the issue.

It looks like it breaks more than just TCP info output, please see [1].
Because of the impact this issue seems to have, do you think it could be
possible to have a v6.7.1 version including this revert patch or the fix
from [1]?

> The order of the columns enum is order sensistive.

I think the modification Quentin did regarding the column order was
correct when looking at:
- what is being displayed: process info (PROC), then the rest (EXT)
- the order in the "columns" array: "Process" (PROC), then "" (EXT)

The issue seems to be due to the "current_field" pointer that is never
switched to the last column, but get stuck to the one before. I tried to
explain this in [1]. Please note that this fix makes sense if the order
of the columns is "PROC", then "EXT" as suggested by Quentin.

[1]
https://lore.kernel.org/netdev/20240113-ss-fix-ext-col-disabled-v1-1-cf99a7381dec@kernel.org/

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.