netdev - Re: [PATCH net v2] net: phy: Fix possible NULL pointer dereference issues caused by phy_attached_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZaUWztbMPhbApPIH@shell.armlinux.org.uk>
Date: Mon, 15 Jan 2024 11:28:14 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Kunwu Chan <chentao@...inos.cn>
Cc: andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: phy: Fix possible NULL pointer dereference
 issues caused by phy_attached_info_irq

On Mon, Jan 15, 2024 at 04:50:18PM +0800, Kunwu Chan wrote:
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index ed0b4ccaa6a6..819574a06036 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1886,7 +1886,7 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy,
>  	irq_str = phy_attached_info_irq(phy);
>  	phylink_info(pl,
>  		     "PHY [%s] driver [%s] (irq=%s)\n",
> -		     dev_name(&phy->mdio.dev), phy->drv->name, irq_str);
> +		     dev_name(&phy->mdio.dev), phy->drv->name, irq_str ? irq_str : "");


		     dev_name(&phy->mdio.dev), phy->drv->name,
		     irq_str ? irq_str : "");

please.

Also, please hold off posting v3 until at least 24 hours have passed.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!