[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <934627c5-eebb-4626-be23-cfb134c01d1a@arista.com>
Date: Mon, 15 Jan 2024 18:05:10 +0000
From: Dmitry Safonov <dima@...sta.com>
To: "Nassiri, Mohammad" <mnassiri@...na.com>
Cc: Shuah Khan <shuah@...nel.org>, David Ahern <dsahern@...nel.org>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Salam Noureddine <noureddine@...sta.com>, Bob Gilligan
<gilligan@...sta.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Dmitry Safonov <0x7f454c46@...il.com>
Subject: Re: [PATCH 12/12] selftests/net: Add TCP-AO key-management test
Hi Mohammad,
On 1/12/24 18:57, Nassiri, Mohammad wrote:
>> -----Original Message-----
>> From: Dmitry Safonov <dima@...sta.com>
>> Sent: Thursday, December 14, 2023 9:36 PM
>
>> +
>> +static void end_server(const char *tst_name, int sk,
>> + struct tcp_ao_counters *begin) {
>> + struct tcp_ao_counters end;
>> +
>> + if (test_get_tcp_ao_counters(sk, &end))
>> + test_error("test_get_tcp_ao_counters()");
>> + verify_keys(tst_name, sk, false, true);
>> +
>> + synchronize_threads(); /* 4: verified => closed */
>> + close(sk);
>> +
>> + verify_counters(tst_name, true, false, begin, &end);
>
> Shouldn't it be reversed instead?
> verify_counters(tst_name, false, true, begin, &end);
> The sk is an accept socket and the function is called by the server.
Good catch!
Do you want to send a patch? :-)
>> + synchronize_threads(); /* 5: counters */ }
>> +
>> +int main(int argc, char *argv[])
>> +{
>> + test_init(120, server_fn, client_fn);
>> + return 0;
>> +}
>>
>> --
>> 2.43.0
>
Thanks,
Dmitry
Powered by blists - more mailing lists