netdev - Re: [PATCH iwl-next v3 2/3] ixgbe: Fix smatch warnings after type convertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a2bbad4-f5c6-4a46-8dc1-ff853987bd59@moroto.mountain>
Date: Thu, 18 Jan 2024 17:02:36 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, anthony.l.nguyen@...el.com,
	netdev@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH iwl-next v3 2/3] ixgbe: Fix smatch warnings after type
 convertion

Thanks for this patch!

On Thu, Jan 18, 2024 at 02:43:31PM +0100, Jedrzej Jagielski wrote:
> Converting s32 functions to regular int in the patch 8035560dbfaf caused
> trigerring smatch warnings about missing error code. The bug predates
> the mentioned patch.

It's not really a bug, just some suspicous code.  Especially the
"If 10G disabled for LPLU via NVM D10GMP, then return no valid LCD"
return.  But it's actually all fine so this patch is really just a
cleanup.

> 
> New smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status'
> 
> Old smatch warnings:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() warn: missing error code? 'status'
> 
> Fix it by clearly stating returning error code as 0.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202401041701.6QKTsZmx-lkp@intel.com/
> Fixes: 6ac743945960 ("ixgbe: Add support for entering low power link up state")

No need for a Fixes tag.

> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>

Thanks, again.  I do think this makes it a lot more clear.

regards,
dan carpenter