netdev - Re: [PATCH net] idpf: distinguish vports by the dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dd14272-eacd-43e5-acff-eb97d0442e44@intel.com>
Date: Thu, 18 Jan 2024 14:41:40 -0800
From: Jesse Brandeburg <jesse.brandeburg@...el.com>
To: Michal Schmidt <mschmidt@...hat.com>, <intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>, "Alan
 Brady" <alan.brady@...el.com>, Pavan Kumar Linga
	<pavan.kumar.linga@...el.com>, Sridhar Samudrala
	<sridhar.samudrala@...el.com>, Shailendra Bhatnagar
	<shailendra.bhatnagar@...el.com>
Subject: Re: [PATCH net] idpf: distinguish vports by the dev_port attribute

On 1/18/2024 12:50 PM, Michal Schmidt wrote:
> idpf registers multiple netdevs (virtual ports) for one PCI function,
> but it does not provide a way for userspace to distinguish them with
> sysfs attributes. Per Documentation/ABI/testing/sysfs-class-net, it is
> a bug not to set dev_port for independent ports on the same PCI bus,
> device and function.
> 
> Without dev_port set, systemd-udevd's default naming policy attempts
> to assign the same name ("ens2f0") to all four idpf netdevs on my test
> system and obviously fails, leaving three of them with the initial
> eth<N> name.
> 
> With this patch, systemd-udevd is able to assign unique names to the
> netdevs (e.g. "ens2f0", "ens2f0d1", "ens2f0d2", "ens2f0d3").
> 
> The Intel-provided out-of-tree idpf driver already sets dev_port. In
> this patch I chose to do it in the same place in the idpf_cfg_netdev
> function.
> 
> Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration")
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

LGTM! Thanks Michal! I checked our latest internal development branch
and it matches what you've added here.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>