netdev - Re: [PATCH net] llc: make llc_ui_sendmsg() more robust against bonding changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240118223500.44066-1-kuniyu@amazon.com>
Date: Thu, 18 Jan 2024 14:35:00 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <kuba@...nel.org>,
	<kuniyu@...zon.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<syzbot+2a7024e9502df538e8ef@...kaller.appspotmail.com>
Subject: Re: [PATCH net] llc: make llc_ui_sendmsg() more robust against bonding changes

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 18 Jan 2024 23:14:21 +0100
> On Thu, Jan 18, 2024 at 10:59 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
> >
> 
> > Probably we need not check SOCK_ZAPPED again after llc_ui_autobind() ?
> >
> 
> Possibly, I was not sure if the socket could be disconnected or not.
> 
> This would be a nop, or a correct check if disconnect is implemented.
> 
> Do you see a problem with a strict validation ?
> 
> I am tired of syzbot reports about llc, I want to add every possible checks.

Agreed, no problem.

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>