[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240119070847.5402-1-linma@zju.edu.cn>
Date: Fri, 19 Jan 2024 15:08:47 +0800
From: Lin Ma <linma@....edu.cn>
To: davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
dsahern@...nel.org,
razor@...ckwall.org,
leon@...nel.org,
linma@....edu.cn,
haleyb.dev@...il.com,
ja@....bg,
judyhsiao@...omium.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH net-next v1] neighbour: complement nl_ntbl_parm_policy
In the neightbl_set function, the attributes array is parsed and validated
using the nl_ntbl_parm_policy policy. However, this policy overlooks the
NDTPA_QUEUE_LENBYTES attribute since the commit 6b3f8674bccb ("[NEIGH]:
Convert neighbour table modification to new netlink api").
As a result, no validation is performed when accessing the
NDTPA_QUEUE_LENBYTES attribute.
This patch addresses this issue by complementing the policy to ensure that
every attribute being accessed is properly validated.
Signed-off-by: Lin Ma <linma@....edu.cn>
---
net/core/neighbour.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 552719c3bbc3..ece0447cf409 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2293,6 +2293,7 @@ static const struct nla_policy nl_neightbl_policy[NDTA_MAX+1] = {
static const struct nla_policy nl_ntbl_parm_policy[NDTPA_MAX+1] = {
[NDTPA_IFINDEX] = { .type = NLA_U32 },
[NDTPA_QUEUE_LEN] = { .type = NLA_U32 },
+ [NPTPA_QUEUE_LEN_BYTES] = { .type = NLA_U32 },
[NDTPA_PROXY_QLEN] = { .type = NLA_U32 },
[NDTPA_APP_PROBES] = { .type = NLA_U32 },
[NDTPA_UCAST_PROBES] = { .type = NLA_U32 },
--
2.34.1
Powered by blists - more mailing lists