netdev - Re: [PATCH net] net: fix removing a namespace with conflicting altnames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL2Cfy6yfY5xF-n+4OEyzCVGm__nH_xo3t0jy8zL8KW+g@mail.gmail.com>
Date: Fri, 19 Jan 2024 14:23:32 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	Марк Коренберг <socketpair@...il.com>, 
	daniel@...earbox.net, jiri@...nulli.us, lucien.xin@...il.com, 
	johannes.berg@...el.com
Subject: Re: [PATCH net] net: fix removing a namespace with conflicting altnames

On Fri, Jan 19, 2024 at 1:59 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Mark reports a BUG() when a net namespace is removed.
>
>     kernel BUG at net/core/dev.c:11520!
>
> Physical interfaces moved outside of init_net get "refunded"
> to init_net when that namespace disappears. The main interface
> name may get overwritten in the process if it would have
> conflicted. We need to also discard all conflicting altnames.
> Recent fixes addressed ensuring that altnames get moved
> with the main interface, which surfaced this problem.
>
> Reported-by: Марк Коренберг <socketpair@...il.com>
> Link: https://lore.kernel.org/all/CAEmTpZFZ4Sv3KwqFOY2WKDHeZYdi0O7N5H1nTvcGp=SAEavtDg@mail.gmail.com/
> Fixes: 7663d522099e ("net: check for altname conflicts when changing netdev's netns")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: daniel@...earbox.net
> CC: jiri@...nulli.us
> CC: lucien.xin@...il.com
> CC: johannes.berg@...el.com
>
> I'll follow up with a conversion to RCU freeing in -next.

Okay then...

Reviewed-by: Eric Dumazet <edumazet@...gle.com>