netdev - Re: [PATCH net] net: fix removing a namespace with conflicting altnames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZaqSJU1FzvNAKBiH@nanopsycho>
Date: Fri, 19 Jan 2024 16:15:49 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com,
	Марк Коренберг <socketpair@...il.com>,
	daniel@...earbox.net, lucien.xin@...il.com, johannes.berg@...el.com
Subject: Re: [PATCH net] net: fix removing a namespace with conflicting
 altnames

Fri, Jan 19, 2024 at 01:58:59AM CET, kuba@...nel.org wrote:
>Mark reports a BUG() when a net namespace is removed.
>
>    kernel BUG at net/core/dev.c:11520!
>
>Physical interfaces moved outside of init_net get "refunded"
>to init_net when that namespace disappears. The main interface
>name may get overwritten in the process if it would have
>conflicted. We need to also discard all conflicting altnames.
>Recent fixes addressed ensuring that altnames get moved
>with the main interface, which surfaced this problem.
>
>Reported-by: Марк Коренберг <socketpair@...il.com>
>Link: https://lore.kernel.org/all/CAEmTpZFZ4Sv3KwqFOY2WKDHeZYdi0O7N5H1nTvcGp=SAEavtDg@mail.gmail.com/
>Fixes: 7663d522099e ("net: check for altname conflicts when changing netdev's netns")
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>