netdev - Re: [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1fc9c7e-20fd-76ac-15e5-b50dcfc1ae9d@intel.com>
Date: Mon, 22 Jan 2024 13:18:57 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to
 int



On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
> Currently big amount of the functions returning standard error codes
> are of type s32. Convert them to regular ints as typdefs here are not
> necessary to return standard error codes.
> 
> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>

There's various checkpatch issues being reported:

CHECK: Alignment should match open parenthesis
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: please, no space before tabs

Seems like a number of these can be remedied.

Thanks,
Tony