netdev - RE: [PATCH iwl-next v3 3/3] ixgbe: Cleanup after type convertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DS0PR11MB7785B40DAD766F1C31FFAB87F07B2@DS0PR11MB7785.namprd11.prod.outlook.com>
Date: Wed, 24 Jan 2024 12:34:42 +0000
From: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH iwl-next v3 3/3] ixgbe: Cleanup after type convertion

From: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com> 
Sent: Thursday, January 18, 2024 3:34 PM

>On 1/18/24 14:43, Jedrzej Jagielski wrote:
>> Clean up code where touched during type convertion by the patch
>> 8035560dbfaf. Rearrange to fix reverse Christmas tree
>I don't see this SHA in my copy, please fix it.

I see this as the SHA of the patch 1/3 'ixgbe: Convert ret val type from s32 to int'
What is the SHA of this patch in your copy then?

>
>> 
>> Suggested-by: Tony Nguyen <anthony.l.nguyen@...el.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
>> ---
>>   .../net/ethernet/intel/ixgbe/ixgbe_82598.c    | 14 ++--
>>   .../net/ethernet/intel/ixgbe/ixgbe_82599.c    | 40 +++++------
>>   .../net/ethernet/intel/ixgbe/ixgbe_common.c   | 66 +++++++++----------
>>   .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |  2 +-
>>   drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  | 54 +++++++--------
>>   drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 12 ++--
>>   drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 50 +++++++-------
>>   7 files changed, 119 insertions(+), 119 deletions(-)
>> 
>
>code changes are fine,
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>