netdev - RE: [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DS0PR11MB778565E31D41DF8F8129E1E0F07A2@DS0PR11MB7785.namprd11.prod.outlook.com>
Date: Thu, 25 Jan 2024 10:16:43 +0000
From: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to
 int

From: Nguyen, Anthony L <anthony.l.nguyen@...el.com> 
Sent: Monday, January 22, 2024 10:19 PM

>On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
>> Currently big amount of the functions returning standard error codes
>> are of type s32. Convert them to regular ints as typdefs here are not
>> necessary to return standard error codes.
>> 
>> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
>> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
>
>There's various checkpatch issues being reported:
>
>CHECK: Alignment should match open parenthesis
>ERROR: space prohibited before that ',' (ctx:WxW)
>WARNING: please, no space before tabs
>
>Seems like a number of these can be remedied.

Can they be addressed in the separate, already existing clean up patch.
Or obligatorily they must be remedied in this patch?

Thanks

>
>Thanks,
>Tony