netdev - Re: [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ac35203-d067-faa9-ef6c-227143b5ab14@intel.com>
Date: Thu, 25 Jan 2024 11:31:40 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to
 int



On 1/25/2024 2:16 AM, Jagielski, Jedrzej wrote:
> From: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Sent: Monday, January 22, 2024 10:19 PM
> 
>> On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
>>> Currently big amount of the functions returning standard error codes
>>> are of type s32. Convert them to regular ints as typdefs here are not
>>> necessary to return standard error codes.
>>>
>>> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
>>> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
>>
>> There's various checkpatch issues being reported:
>>
>> CHECK: Alignment should match open parenthesis
>> ERROR: space prohibited before that ',' (ctx:WxW)
>> WARNING: please, no space before tabs
>>
>> Seems like a number of these can be remedied.
> 
> Can they be addressed in the separate, already existing clean up patch.
> Or obligatorily they must be remedied in this patch?

We shouldn't introduce anything new to be cleaned up later, which is 
hard to tell with everything that pops up. My thought would be to have a 
cleanup patch before this to preemptively resolve what we can, then it 
would be easier to review anything that pops up here.

Thanks,
Tony