netdev - Re: [net-next v5 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e7757c7ddc4cd0bb4256d893b65aa53b549d052.camel@redhat.com>
Date: Tue, 23 Jan 2024 13:24:04 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jinjian Song <songjinjian@...mail.com>, netdev@...r.kernel.org
Cc: chandrashekar.devegowda@...el.com, chiranjeevi.rapolu@...ux.intel.com, 
 haijun.liu@...iatek.com, m.chetan.kumar@...ux.intel.com, 
 ricardo.martinez@...ux.intel.com, loic.poulain@...aro.org, 
 ryazanov.s.a@...il.com, johannes@...solutions.net, davem@...emloft.net, 
 edumazet@...gle.com, kuba@...nel.org, linux-kernel@...r.kernel.com, 
 vsankar@...ovo.com, danielwinkler@...gle.com, nmarupaka@...gle.com, 
 joey.zhao@...ocom.com, liuqf@...ocom.com, felix.yan@...ocom.com, Jinjian
 Song <jinjian.song@...ocom.com>
Subject: Re: [net-next v5 2/4] net: wwan: t7xx: Add sysfs attribute for
 device state machine

On Mon, 2024-01-22 at 17:09 +0800, Jinjian Song wrote:
[...]
> +static ssize_t t7xx_mode_store(struct device *dev,
> +			       struct device_attribute *attr,
> +			       const char *buf, size_t count)
> +{
> +	int index = 0;
> +	struct pci_dev *pdev;
> +	struct t7xx_pci_dev *t7xx_dev;

Minor nit: please respect the reverse x-mas tree, here and in more
places below.

Cheers,

Paolo