[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<MEYP282MB26973EE72246EB515506EAD6BB7B2@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
Date: Thu, 25 Jan 2024 00:56:38 +0800
From: Jinjian Song <songjinjian@...mail.com>
To: pabeni@...hat.com,
Jinjian Song <songjinjian@...mail.com>,
netdev@...r.kernel.org
Cc: chandrashekar.devegowda@...el.com,
chiranjeevi.rapolu@...ux.intel.com,
danielwinkler@...gle.com,
davem@...emloft.net,
edumazet@...gle.com,
felix.yan@...ocom.com,
haijun.liu@...iatek.com,
jinjian.song@...ocom.com,
joey.zhao@...ocom.com,
johannes@...solutions.net,
kuba@...nel.org,
linux-kernel@...r.kernel.com,
liuqf@...ocom.com,
loic.poulain@...aro.org,
m.chetan.kumar@...ux.intel.com,
nmarupaka@...gle.com,
ricardo.martinez@...ux.intel.com,
ryazanov.s.a@...il.com,
vsankar@...ovo.com
Subject: Re: [net-next v5 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine
From: Paolo Abeni <pabeni@...hat.com>
>On Mon, 2024-01-22 at 17:09 +0800, Jinjian Song wrote:
>[...]
>> +static ssize_t t7xx_mode_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t count)
>> +{
>> + int index = 0;
>> + struct pci_dev *pdev;
>> + struct t7xx_pci_dev *t7xx_dev;
>
>Minor nit: please respect the reverse x-mas tree, here and in more
>places below.
Please let me change the as that.
Best Regards,
Jinjian
Powered by blists - more mailing lists