netdev - Re: pull-request: wireless-2024-01-22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6940d0a80fcb522910c433fd3644ed5c524f6d5.camel@sipsolutions.net>
Date: Tue, 23 Jan 2024 23:06:20 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Kalle Valo <kvalo@...nel.org>, Lukas Bulwahn <lukas.bulwahn@...il.com>, 
 netdev@...r.kernel.org, linux-wireless@...r.kernel.org, David Gow
 <davidgow@...gle.com>, Brendan Higgins <brendanhiggins@...gle.com>, Shuah
 Khan <skhan@...uxfoundation.org>, linux-kselftest@...r.kernel.org, 
 kunit-dev@...glegroups.com
Subject: Re: pull-request: wireless-2024-01-22

On Tue, 2024-01-23 at 13:42 -0800, Jakub Kicinski wrote:
> 
> > We're also adding unit tests to iwlwifi (slowly), any idea if we should
> > enable that here also? It _is_ now possible to build PCI stuff on kunit,
> > but it requires some additional config options (virt-pci etc.), not sure
> > that's desirable here? It doesn't need it at runtime for the tests, of
> > course.
> 
> but curious to hear about driver testing recommendations.

Not sure I have any recommendations ... The test we posted is checking
an invariant (the devinfo array is sorted in the right way); we used to
have a check for this in the internal driver variant at init time, now
it's a kunit test and we don't have to carry the delta to upstream here.

I think Miri is also working on some additional tests for some driver-
internal logic though.

So not sure, I guess it'd be just like anything else you could use unit
testing for, certain self-contained parts of the code that don't really
otherwise need a device, etc.?

johannes