netdev - Re: pull-request: wireless-2024-01-22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 14:51:28 +0800
From: David Gow <davidgow@...gle.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>, netdev@...r.kernel.org, 
	linux-wireless@...r.kernel.org, Brendan Higgins <brendanhiggins@...gle.com>, 
	Shuah Khan <skhan@...uxfoundation.org>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com
Subject: Re: pull-request: wireless-2024-01-22

On Wed, 24 Jan 2024 at 02:22, Johannes Berg <johannes@...solutions.net> wrote:
>
> On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote:
> >
> > We're also adding unit tests to iwlwifi (slowly), any idea if we should
> > enable that here also? It _is_ now possible to build PCI stuff on kunit,
> > but it requires some additional config options (virt-pci etc.), not sure
> > that's desirable here? It doesn't need it at runtime for the tests, of
> > course.
> >
>
> Heh, in fact Miri just posted the first bits:
>
> https://lore.kernel.org/r/20240123200528.a4a8af7c091f.I0fb09083317b331168b99b8db39656a126a5cc4d@changeid
>
>
> Also, should enabling that in
> tools/testing/kunit/configs/all_tests.config go through our tree, or
> better through the kselftest tree?
>

I'd definitely like the iwlwifi tests to be enabled in all_tests.config.

The virt-pci options _should_ already be enabled for the UML configs
under kunit.py by default now (they're in
.../configs/arch_uml.config).

I don't mind which tree the changes to all_tests.config go through --
I suspect it's probably better for them to go in via your tree,
particularly if they end up depending on any new config options.

-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4014 bytes)