netdev - Re: [TEST] bond_options.sh looks flaky

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Za9oJmof6QYVHw52@Laptop-X1>
Date: Tue, 23 Jan 2024 15:17:58 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Jay Vosburgh <jay.vosburgh@...onical.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	Benjamin Poirier <bpoirier@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [TEST] bond_options.sh looks flaky

On Tue, Jan 23, 2024 at 11:56:15AM +0800, Hangbin Liu wrote:
> > 3) I'm not sure why this test fails, but the prior test that claims to
> > be active-backup does not, even though both appear to be actually
> > testing active-backup.  The log entries for the actual "prio
> > (active-backup arp_ip_target primary_reselect 1)" test start at time
> > 281.913374, and differ from the failing test starting at 715.597039.
> 
> From the passed log
> 
> [  505.516927] br0: port 2(s1) entered disabled state
> [  505.773009] bond0: (slave eth1): link status definitely down, disabling slave
> [  505.773593] bond0: (slave eth2): making interface the new active one
> 
> While the failed log
> [  723.603062] br0: port 4(s2) entered disabled state
> [  723.868750] bond0: (slave eth2): link status definitely down, disabling slave
> [  723.869104] bond0: (slave eth1): making interface the new active one
> 
> It looks the wrong active link was set. It should be eth1 but set to eth2.
> So the later link operation set eth2 link down. Not sure why eth2 was set to
> active interface. I need to print log immediately if check_err failed.

Ah, the log did print the error message:

# TEST: prio (balance-alb arp_ip_target primary_reselect 1)           [FAIL]
# Current active slave is eth2 but not eth1

>From the log, not sure why eth0/eth1 down and thus the eth2 become the active
one.

[  716.115869] bond0: (slave eth1): making interface the new active one
[  716.116914] bond0: (slave eth1): Enslaving as an active interface with an up link
[  716.117792] br0: port 2(s1) entered blocking state
[  716.118022] br0: port 2(s1) entered forwarding state
[  716.234644] bond0: (slave eth2): Enslaving as a backup interface with an up link
[  716.235716] br0: port 4(s2) entered blocking state
[  716.235926] br0: port 4(s2) entered forwarding state
[  716.373537] bond0: (slave eth0): link status definitely down, disabling slave
[  716.374651] bond0: (slave eth1): link status definitely down, disabling slave
[  716.374920] bond0: (slave eth2): making interface the new active one
[  716.484168] bond0: (slave eth0): link status definitely up
[  716.484909] bond0: (slave eth1): link status definitely up


For other passed test you can see the eth0/eth1 was not set to down. So eth1
keep as the active one.

[  498.558083] bond0: (slave eth1): making interface the new active one
[  498.558973] bond0: (slave eth1): Enslaving as an active interface with an up link
[  498.559724] br0: port 2(s1) entered blocking state
[  498.559962] br0: port 2(s1) entered forwarding state
[  498.632107] bond0: (slave eth2): Enslaving as a backup interface with an up link
[  498.636366] br0: port 4(s2) entered blocking state
[  498.636684] br0: port 4(s2) entered forwarding state

Thanks
Hangbin