netdev - Re: [PATCH iproute2] vxlan: add support for flowlab inherit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1793b6c1-9dba-4794-ae0d-5eda4f6db663@bernat.ch>
Date: Tue, 23 Jan 2024 08:58:15 +0100
From: Vincent Bernat <vincent@...nat.ch>
To: David Ahern <dsahern@...il.com>, Ido Schimmel <idosch@...sch.org>,
 Alce Lafranque <alce@...ranque.net>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2] vxlan: add support for flowlab inherit

On 2024-01-23 01:41, David Ahern wrote:
>> My personal
>> preference would be to add a new keyword for the new attribute:
>>
>> # ip link set dev vx0 type vxlan flowlabel_policy inherit
>> # ip link set dev vx0 type vxlan flowlabel_policy fixed flowlabel 10
>>
>> But let's see what David thinks.
>>
> 
> A new keyword for the new attribute seems like the most robust.
> 
> That said, inherit is already used in several ip commands for dscp, ttl
> and flowlabel for example; I do not see a separate keyword - e.g.,
> ip6tunnel.c.

The implementation for flowlabel was modeled along ttl. We did diverge 
for kernel, we can diverge for iproute2 as well. However, I am unsure if 
you say we should go for option A (new attribute) or option B (do like 
for dscp/ttl).