netdev - Re: [PATCH iwl-next 2/2] ice: make ice_vsi_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240124100942.GT254773@kernel.org>
Date: Wed, 24 Jan 2024 10:09:42 +0000
From: Simon Horman <horms@...nel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	anthony.l.nguyen@...el.com, magnus.karlsson@...el.com
Subject: Re: [PATCH iwl-next 2/2] ice: make ice_vsi_cfg_txq() static

On Tue, Jan 23, 2024 at 12:58:46PM +0100, Maciej Fijalkowski wrote:
> Currently, XSK control path in ice driver calls directly
> ice_vsi_cfg_txq() whereas we have ice_vsi_cfg_single_txq() for that
> purpose. Use the latter from XSK side and make ice_vsi_cfg_txq() static.
> 
> ice_vsi_cfg_txq() resides in ice_base.c and is rather big, so to reduce
> the code churn let us move the callers of it from ice_lib.c to
> ice_base.c.
> 
> This change puts ice_qp_ena() on nice diet due to the checks and
> operations that ice_vsi_cfg_single_{r,t}xq() do internally.
> 
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-182 (-182)
> Function                                     old     new   delta
> ice_xsk_pool_setup                          2165    1983    -182
> Total: Before=472597, After=472415, chg -0.04%
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>