netdev - RE: [Intel-wired-lan] [PATCH iwl-next 2/2] ice: make ice_vsi_cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH3PR11MB831373EBBBBB792631610427EA7C2@CH3PR11MB8313.namprd11.prod.outlook.com>
Date: Wed, 31 Jan 2024 03:16:35 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Karlsson, Magnus" <magnus.karlsson@...el.com>,
	"Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>, "Nagraj, Shravan"
	<shravan.nagraj@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next 2/2] ice: make
 ice_vsi_cfg_txq() static



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Tuesday, January 23, 2024 5:29 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: netdev@...r.kernel.org; Fijalkowski, Maciej
><maciej.fijalkowski@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Karlsson, Magnus
><magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH iwl-next 2/2] ice: make ice_vsi_cfg_txq() static
>
>Currently, XSK control path in ice driver calls directly
>ice_vsi_cfg_txq() whereas we have ice_vsi_cfg_single_txq() for that purpose.
>Use the latter from XSK side and make ice_vsi_cfg_txq() static.
>
>ice_vsi_cfg_txq() resides in ice_base.c and is rather big, so to reduce the code
>churn let us move the callers of it from ice_lib.c to ice_base.c.
>
>This change puts ice_qp_ena() on nice diet due to the checks and operations
>that ice_vsi_cfg_single_{r,t}xq() do internally.
>
>add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-182 (-182)
>Function                                     old     new   delta
>ice_xsk_pool_setup                          2165    1983    -182
>Total: Before=472597, After=472415, chg -0.04%
>
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_base.c | 76 ++++++++++++++++++++++-
>drivers/net/ethernet/intel/ice/ice_base.h |  7 ++-
>drivers/net/ethernet/intel/ice/ice_lib.c  | 73 ----------------------
>drivers/net/ethernet/intel/ice/ice_lib.h  |  6 --
>drivers/net/ethernet/intel/ice/ice_xsk.c  | 20 +-----
> 5 files changed, 82 insertions(+), 100 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)