netdev - Re: [PATCH] ipv6: Ensure natural alignment of const ipv6 loopback and router addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2d71d3d01211af31e706acf386904760bae8301.camel@redhat.com>
Date: Thu, 25 Jan 2024 09:41:04 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Helge Deller <deller@...nel.org>, "David S. Miller"
 <davem@...emloft.net>,  netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-parisc@...r.kernel.org
Subject: Re: [PATCH] ipv6: Ensure natural alignment of const ipv6 loopback
 and router addresses

On Mon, 2024-01-22 at 22:27 +0100, Helge Deller wrote:
> On a parisc64 kernel I notice sometimes this kernel warning:
> Kernel unaligned access to 0x40ff8814 at ndisc_send_skb+0xc0/0x4d8
> 
> The address 0x40ff8814 points to the in6addr_linklocal_allrouters
> variable and the warning simply means that some ipv6 function tries to
> read a 64-bit word directly from the not-64-bit aligned
> in6addr_linklocal_allrouters variable.
> 
> The patch below ensures that those ipv6 loopback and router addresses
> always will be naturally aligned and as such prevents unaligned accesses
> for all architectures.
> 
> Signed-off-by: Helge Deller <deller@....de>

The patch LGTM, but the above looks like material for the 'net' tree,
would you mind sending a v2 including a relevant fixes tag, the target
tree in the subject prefix and possibly the stacktrace you observe?

Feel free to include my acked-by tag in v2.

Thanks,

Paolo