netdev - Re: [PATCH 4/6 iwl-next] idpf: refactor remaining virtchnl messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65b1d2b755e27_250560294e8@willemb.c.googlers.com.notmuch>
Date: Wed, 24 Jan 2024 22:17:11 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Alan Brady <alan.brady@...el.com>, 
 intel-wired-lan@...ts.osuosl.org
Cc: netdev@...r.kernel.org, 
 Alan Brady <alan.brady@...el.com>, 
 Przemek Kitszel <przemyslaw.kitszel@...el.com>, 
 Igor Bagnucki <igor.bagnucki@...el.com>
Subject: Re: [PATCH 4/6 iwl-next] idpf: refactor remaining virtchnl messages

Alan Brady wrote:
> This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This
> again is mostly mechanical. There's some added functionality with MAC
> filters which makes sure we remove bad filters now that we can better
> handle asynchronous messages.

Can you split the part that is pure refactor and the part that is new
functionality?

That will make reviewing both easier. The first should be a NOOP.

> There's still a bit more cleanup we can do here to remove stuff that's
> not being used anymore now; follow-up patch will take care of loose
> ends.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Igor Bagnucki <igor.bagnucki@...el.com>
> Signed-off-by: Alan Brady <alan.brady@...el.com>
> ---
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 933 +++++++-----------
>  1 file changed, 375 insertions(+), 558 deletions(-)