netdev - Re: [PATCH 4/6 iwl-next] idpf: refactor remaining virtchnl messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0773912d-28bd-479f-ae1d-8aa5c636ee52@intel.com>
Date: Thu, 25 Jan 2024 09:01:18 -0800
From: "Brady, Alan" <alan.brady@...el.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Igor Bagnucki <igor.bagnucki@...el.com>
Subject: Re: [PATCH 4/6 iwl-next] idpf: refactor remaining virtchnl messages

On 1/24/2024 7:17 PM, Willem de Bruijn wrote:
> Alan Brady wrote:
>> This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This
>> again is mostly mechanical. There's some added functionality with MAC
>> filters which makes sure we remove bad filters now that we can better
>> handle asynchronous messages.
> Can you split the part that is pure refactor and the part that is new
> functionality?
>
> That will make reviewing both easier. The first should be a NOOP.


Sure thing. Added functionality is fairly well isolated to 
idpf_mac_filter_async_handler so should be straightforward to split it.

-Alan


>> There's still a bit more cleanup we can do here to remove stuff that's
>> not being used anymore now; follow-up patch will take care of loose
>> ends.
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> Reviewed-by: Igor Bagnucki <igor.bagnucki@...el.com>
>> Signed-off-by: Alan Brady <alan.brady@...el.com>
>> ---
>>   .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 933 +++++++-----------
>>   1 file changed, 375 insertions(+), 558 deletions(-)