[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2477cf4a-6824-4997-aef8-3f8e5f9b2399@lunn.ch>
Date: Thu, 25 Jan 2024 17:59:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Michal Vokáč <michal.vokac@...ft.com>
Cc: Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Christian Marangi <ansuelsmth@...il.com>,
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
Marek Behún <kabel@...nel.org>,
Christian Lamparter <chunkeey@...il.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, petr.benes@...ft.com
Subject: Re: [PATCH net v2] net: dsa: qca8k: fix illegal usage of GPIO
> diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
> index ec57d9d52072..3663de8f2617 100644
> --- a/drivers/net/dsa/qca/qca8k-8xxx.c
> +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
> @@ -2037,13 +2037,11 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
> priv->dev = &mdiodev->dev;
> priv->info = of_device_get_match_data(priv->dev);
>
> - priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
> - GPIOD_ASIS);
> + priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset", GPIOD_OUT_HIGH);
Sorry, i should of pointed this out on the previous version. netdev
kept with 80 character lines. That is why what you deleted was split
over two lines, and what you add should also split at the same point.
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists