netdev - Re: [PATCH net v2] net: dsa: qca8k: fix illegal usage of GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84e362b0-9a9f-461b-b472-a9b3666cb94b@ysoft.com>
Date: Fri, 26 Jan 2024 11:14:22 +0100
From: Michal Vokáč <michal.vokac@...ft.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Florian Fainelli <f.fainelli@...il.com>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Christian Marangi <ansuelsmth@...il.com>,
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Marek Behún <kabel@...nel.org>,
 Christian Lamparter <chunkeey@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, petr.benes@...ft.com
Subject: Re: [PATCH net v2] net: dsa: qca8k: fix illegal usage of GPIO

On 25. 01. 24 17:59, Andrew Lunn wrote:
>> diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
>> index ec57d9d52072..3663de8f2617 100644
>> --- a/drivers/net/dsa/qca/qca8k-8xxx.c
>> +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
>> @@ -2037,13 +2037,11 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
>>   	priv->dev = &mdiodev->dev;
>>   	priv->info = of_device_get_match_data(priv->dev);
>>   
>> -	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
>> -						   GPIOD_ASIS);
>> +	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset", GPIOD_OUT_HIGH);
> 
> Sorry, i should of pointed this out on the previous version. netdev
> kept with 80 character lines. That is why what you deleted was split
> over two lines, and what you add should also split at the same point.
OK, no problem I will fix that. I did not realize, that netdev kept
that rule.

Michal