netdev - Re: [PATCH net-next 0/6] selftests: Add TEST_INCLUDES directive and adjust tests to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 12:07:45 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Petr Machata <petrm@...dia.com>,
	Danielle Ratson <danieller@...dia.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Ido Schimmel <idosch@...dia.com>,
	Johannes Nixdorf <jnixdorf-oss@....de>,
	Davide Caratti <dcaratti@...hat.com>,
	Tobias Waldekranz <tobias@...dekranz.com>,
	Zahari Doychev <zdoychev@...linear.com>,
	linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] selftests: Add TEST_INCLUDES directive and
 adjust tests to use it

On Wed, Jan 24, 2024 at 12:02:16PM -0500, Benjamin Poirier wrote:
> After commit 25ae948b4478 ("selftests/net: add lib.sh") but before commit
> 2114e83381d3 ("selftests: forwarding: Avoid failures to source
> net/lib.sh"), some net selftests encountered errors when they were being
> exported and run. This was because the new net/lib.sh was not exported
> along with the tests. The errors were crudely avoided by duplicating some
> content between net/lib.sh and net/forwarding/lib.sh in 2114e83381d3.
> 
> In order to restore the sourcing of net/lib.sh from net/forwarding/lib.sh
> and remove the duplicated content, this series introduces a new selftests
> Makefile variable to list extra files to export from other directories and
> makes use of it to avoid reintroducing the errors mentioned above.
> 
> v1:
> * "selftests: Introduce Makefile variable to list shared bash scripts"
> Changed TEST_INCLUDES to take relative paths, like other TEST_* variables.
> Paths are adjusted accordingly in the subsequent patches. (Vladimir Oltean)
> 
> * selftests: bonding: Change script interpreter
>   selftests: forwarding: Remove executable bits from lib.sh
> Removed from this series, submitted separately.
> 
> Since commit 2114e83381d3 ("selftests: forwarding: Avoid failures to source
> net/lib.sh") resolved the test errors, this version of the series is
> focused on removing the duplication that was added in that commit. Directly
> rebasing the series would reintroduce the problems that 2114e83381d3
> avoided before fixing them again. In order to prevent such breakage partway
> through the series, patches are reordered and content changed slightly but
> there is no diff at the end compared with the simple rebasing approach. I
> have dropped most review tags on account of this reordering.
> 
> RFC:
> https://lore.kernel.org/netdev/20231222135836.992841-1-bpoirier@nvidia.com/
> 
> Link: https://lore.kernel.org/netdev/ZXu7dGj7F9Ng8iIX@Laptop-X1/
> 

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>