netdev - Re: [PATCH net-next 1/6] selftests: Introduce Makefile variable to list shared bash scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240124204612.4c688095@kernel.org>
Date: Wed, 24 Jan 2024 20:46:12 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, Shuah Khan <shuah@...nel.org>, Jonathan Corbet
 <corbet@....net>, Jay Vosburgh <j.vosburgh@...il.com>, Andy Gospodarek
 <andy@...yhouse.net>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli
 <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Petr Machata
 <petrm@...dia.com>, Danielle Ratson <danieller@...dia.com>, Nikolay
 Aleksandrov <razor@...ckwall.org>, Ido Schimmel <idosch@...dia.com>,
 Johannes Nixdorf <jnixdorf-oss@....de>, Davide Caratti
 <dcaratti@...hat.com>, Tobias Waldekranz <tobias@...dekranz.com>, Zahari
 Doychev <zdoychev@...linear.com>, Hangbin Liu <liuhangbin@...il.com>,
 linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next 1/6] selftests: Introduce Makefile variable to
 list shared bash scripts

On Wed, 24 Jan 2024 12:02:17 -0500 Benjamin Poirier wrote:
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -255,9 +255,19 @@ Contributing new tests (details)
>  
>     TEST_PROGS_EXTENDED, TEST_GEN_PROGS_EXTENDED mean it is the
>     executable which is not tested by default.
> +
>     TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
>     test.
>  
> +   TEST_INCLUDES is similar to TEST_FILES, it lists files which should be
> +   included when exporting or installing the tests, with the following
> +   differences:
> +   * symlinks to files in other directories are preserved
> +   * the part of paths below tools/testing/selftests/ is preserved when copying
> +     the files to the output directory
> +   TEST_INCLUDES is meant to list dependencies located in other directories of
> +   the selftests hierarchy.
> +

I think that this chunk causes a warning when doing make htmldocs:

Documentation/dev-tools/kselftest.rst:267: WARNING: Unexpected indentation.
Documentation/dev-tools/kselftest.rst:268: WARNING: Block quote ends without a blank line; unexpected unindent.

Could you double-check?