netdev - Re: [PATCH net-next] net: free altname using an RCU callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbeIvuPJi6K5aUF0@nanopsycho>
Date: Mon, 29 Jan 2024 12:15:10 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, daniel@...earbox.net, lucien.xin@...il.com,
	johannes.berg@...el.com
Subject: Re: [PATCH net-next] net: free altname using an RCU callback

Fri, Jan 26, 2024 at 09:14:49PM CET, kuba@...nel.org wrote:
>We had to add another synchronize_rcu() in recent fix.
>Bite the bullet and add an rcu_head to netdev_name_node,
>free from RCU.
>
>Note that name_node does not hold any reference on dev
>to which it points, but there must be a synchronize_rcu()
>on device removal path, so we should be fine.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Looks good to me.

Reviewed-by: Jiri Pirko <jiri@...dia.com>