netdev - Re: [PATCH net-next] net: free altname using an RCU callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ1RR6Hkezdg_xDZjvDcMcZHeo-aw3v8Z6erzrhwM8-tg@mail.gmail.com>
Date: Mon, 29 Jan 2024 13:36:53 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	daniel@...earbox.net, jiri@...nulli.us, lucien.xin@...il.com, 
	johannes.berg@...el.com
Subject: Re: [PATCH net-next] net: free altname using an RCU callback

On Fri, Jan 26, 2024 at 9:14 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> We had to add another synchronize_rcu() in recent fix.
> Bite the bullet and add an rcu_head to netdev_name_node,
> free from RCU.
>
> Note that name_node does not hold any reference on dev
> to which it points, but there must be a synchronize_rcu()
> on device removal path, so we should be fine.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>