netdev - RE: [PATCH v1 net-next 00/11] ENA driver changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fab02eb3391341b3b63c5abf9ff74f47@amazon.com>
Date: Tue, 30 Jan 2024 09:39:53 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: "Nelson, Shannon" <shannon.nelson@....com>, David Miller
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "Woodhouse, David" <dwmw@...zon.co.uk>, "Machulsky, Zorik"
	<zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, "Bshara,
 Saeed" <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, "Liguori,
 Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>, "Kiyanovski, Arthur"
	<akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Agroskin, Shay"
	<shayagr@...zon.com>, "Itzko, Shahar" <itzko@...zon.com>, "Abboud, Osama"
	<osamaabb@...zon.com>, "Ostrovsky, Evgeny" <evostrov@...zon.com>, "Tabachnik,
 Ofir" <ofirt@...zon.com>, "Koler, Nati" <nkolder@...zon.com>
Subject: RE: [PATCH v1 net-next 00/11] ENA driver changes

> On 1/29/2024 12:55 AM, darinzon@...zon.com wrote:
> >
> > From: David Arinzon <darinzon@...zon.com>
> >
> > This patchset contains a set of minor and cosmetic changes to the ENA
> > driver.
> 
> A couple of nits noted, but otherwise looks reasonable.
> 
> Reviewed-by: Shannon Nelson <shannon.nelson@....com>
> 
> 

Thanks for taking the time and reviewing the patchset.
I've addressed some of the comments, while the rest will
be fixed in the next patchset version.

David

> >
> > David Arinzon (11):
> >    net: ena: Remove an unused field
> >    net: ena: Add more documentation for RX copybreak
> >    net: ena: Minor cosmetic changes
> >    net: ena: Enable DIM by default
> >    net: ena: Remove CQ tail pointer update
> >    net: ena: Change error print during ena_device_init()
> >    net: ena: Add more information on TX timeouts
> >    net: ena: Relocate skb_tx_timestamp() to improve time stamping
> >      accuracy
> >    net: ena: Change default print level for netif_ prints
> >    net: ena: handle ena_calc_io_queue_size() possible errors
> >    net: ena: Reduce lines with longer column width boundary
> >
> >   .../device_drivers/ethernet/amazon/ena.rst    |   6 +
> >   drivers/net/ethernet/amazon/ena/ena_com.c     | 323 ++++++------------
> >   drivers/net/ethernet/amazon/ena/ena_com.h     |   6 +-
> >   drivers/net/ethernet/amazon/ena/ena_eth_com.c |  49 ++-
> >   drivers/net/ethernet/amazon/ena/ena_eth_com.h |  39 +--
> >   drivers/net/ethernet/amazon/ena/ena_netdev.c  | 161 ++++++---
> >   .../net/ethernet/amazon/ena/ena_regs_defs.h   |   1 +
> >   drivers/net/ethernet/amazon/ena/ena_xdp.c     |   1 -
> >   8 files changed, 258 insertions(+), 328 deletions(-)
> >
> > --
> > 2.40.1
> >
> >