netdev - Re: [patch net-next 0/3] dpll: expose lock status error value to user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b213297b-53f6-4c66-8c0b-5b3fbafdbccd@linux.dev>
Date: Tue, 30 Jan 2024 10:28:56 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net,
 edumazet@...gle.com, arkadiusz.kubalewski@...el.com, saeedm@...dia.com,
 leon@...nel.org, jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
 rrameshbabu@...dia.com
Subject: Re: [patch net-next 0/3] dpll: expose lock status error value to user

On 29/01/2024 14:59, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Allow to expose lock status errort value over new DPLL generic netlink
> attribute. Extend the lock_status_get() op by new argument to get the
> value from the driver. Implement this new argument fill-up
> in mlx5 driver.

The list of errors shows that the focus is on SyncE devices here. What
do you think about extending it to PPS devices too? Like loss of input
frequency, or high phase offset?

But the series overall looks good,

Acked-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>


> Jiri Pirko (3):
>    dpll: extend uapi by lock status error attribute
>    dpll: extend lock_status_get() op by status error and expose to user
>    net/mlx5: DPLL, Implement lock status error value
> 
>   Documentation/netlink/specs/dpll.yaml         | 39 +++++++++++++++++++
>   drivers/dpll/dpll_netlink.c                   |  9 ++++-
>   drivers/net/ethernet/intel/ice/ice_dpll.c     |  1 +
>   .../net/ethernet/mellanox/mlx5/core/dpll.c    | 32 +++++++++++++--
>   drivers/ptp/ptp_ocp.c                         |  9 +++--
>   include/linux/dpll.h                          |  1 +
>   include/linux/mlx5/mlx5_ifc.h                 |  8 ++++
>   include/uapi/linux/dpll.h                     | 30 ++++++++++++++
>   8 files changed, 120 insertions(+), 9 deletions(-)
>