[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202401301831.QfsB6gZg-lkp@intel.com>
Date: Tue, 30 Jan 2024 18:46:15 +0800
From: kernel test robot <lkp@...el.com>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, kuba@...nel.org, pabeni@...hat.com,
davem@...emloft.net, edumazet@...gle.com, vadim.fedorenko@...ux.dev,
arkadiusz.kubalewski@...el.com, saeedm@...dia.com, leon@...nel.org,
jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
rrameshbabu@...dia.com
Subject: Re: [patch net-next 2/3] dpll: extend lock_status_get() op by status
error and expose to user
Hi Jiri,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Jiri-Pirko/dpll-extend-uapi-by-lock-status-error-attribute/20240129-230433
base: net-next/main
patch link: https://lore.kernel.org/r/20240129145916.244193-3-jiri%40resnulli.us
patch subject: [patch net-next 2/3] dpll: extend lock_status_get() op by status error and expose to user
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20240130/202401301831.QfsB6gZg-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/202401301831.QfsB6gZg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401301831.QfsB6gZg-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/ice/ice_dpll.c:505: warning: Function parameter or struct member 'status_error' not described in 'ice_dpll_lock_status_get'
vim +505 drivers/net/ethernet/intel/ice/ice_dpll.c
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 485
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 486 /**
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 487 * ice_dpll_lock_status_get - get dpll lock status callback
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 488 * @dpll: registered dpll pointer
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 489 * @dpll_priv: private data pointer passed on dpll registration
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 490 * @status: on success holds dpll's lock status
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 491 * @extack: error reporting
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 492 *
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 493 * Dpll subsystem callback, provides dpll's lock status.
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 494 *
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 495 * Context: Acquires pf->dplls.lock
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 496 * Return:
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 497 * * 0 - success
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 498 * * negative - failure
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 499 */
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 500 static int
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 501 ice_dpll_lock_status_get(const struct dpll_device *dpll, void *dpll_priv,
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 502 enum dpll_lock_status *status,
0bbc9a9d0d8c32 Jiri Pirko 2024-01-29 503 enum dpll_lock_status_error *status_error,
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 504 struct netlink_ext_ack *extack)
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 @505 {
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 506 struct ice_dpll *d = dpll_priv;
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 507 struct ice_pf *pf = d->pf;
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 508
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 509 mutex_lock(&pf->dplls.lock);
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 510 *status = d->dpll_state;
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 511 mutex_unlock(&pf->dplls.lock);
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 512
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 513 return 0;
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 514 }
d7999f5ea64bb1 Arkadiusz Kubalewski 2023-09-13 515
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists