netdev - Re: [net-next 13/15] net/mlx5: DR, Change SWS usage to debug fs seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5a7f141-9d49-6208-59e4-39017df3d20b@nvidia.com>
Date: Wed, 31 Jan 2024 03:42:47 +0200
From: Yevgeny Kliteynik <kliteyn@...dia.com>
To: Simon Horman <horms@...nel.org>, Saeed Mahameed <saeed@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Saeed Mahameed <saeedm@...dia.com>,
 netdev@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
 Hamdan Igbaria <hamdani@...dia.com>
Subject: Re: [net-next 13/15] net/mlx5: DR, Change SWS usage to debug fs
 seq_file interface

On 29-Jan-24 22:55, Simon Horman wrote:
> Hi Saeed and Hamdan,
> 
> I am seeing some warnings which I think relate to stack usage like the above,
> combined with inlining.
> 
> clang-17 W=1 build on x86_64 says:
> 
>   .../dr_dbg.c:1071:1: warning: stack frame size (2552) exceeds limit (2048) in 'dr_dump_start' [-Wframe-larger-than]
>    1071 | dr_dump_start(struct seq_file *file, loff_t *pos)
>         | ^
>   .../dr_dbg.c:703:1: warning: stack frame size (2136) exceeds limit (2048) in 'dr_dump_matcher_rx_tx' [-Wframe-larger-than]
>     703 | dr_dump_matcher_rx_tx(struct seq_file *file, bool is_rx,
>         | ^
> 
> gcc-13 W=1 build on x86_64 says:
> 
>   .../dr_dbg.c: In function 'dr_dump_domain':
>   .../dr_dbg.c:1044:1: warning: the frame size of 2096 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>    1044 | }
>         | ^
> 

Indeed, there's an unnecessary long buffer allocated on stack.
Will send v2 soon.

Thanks!

-- YK

>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_dbg.h b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_dbg.h
>> index def6cf853eea..13511716cdbc 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_dbg.h
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_dbg.h
>> @@ -1,10 +1,30 @@
>>   /* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */
>>   /* Copyright (c) 2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved. */
>>
>> +#define MLX5DR_DEBUG_DUMP_BUFF_SIZE (64 * 1024 * 1024)
>> +#define MLX5DR_DEBUG_DUMP_BUFF_LENGTH 1024
> 
> ...