netdev - Add PHC support with error bound value for ENA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8803342f01f54ca38296cedafea10bde@amazon.com>
Date: Thu, 1 Feb 2024 07:24:51 +0000
From: "Bernstein, Amit" <amitbern@...zon.com>
To: "tglx@...utronix.de" <tglx@...utronix.de>, "richardcochran@...il.com"
	<richardcochran@...il.com>
CC: "kuba@...nel.org" <kuba@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Dagan, Noam" <ndagan@...zon.com>, "Arinzon, David"
	<darinzon@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>
Subject: Add PHC support with error bound value for ENA driver

Hi Thomas, Richard and all,

In one of the upcoming releases, we're planning to add PHC support to the ENA driver (/drivers/net/ethernet/amazon/ena/)
To provide the best experience for service customers, the ENA driver will expose an error_bound parameter (expressed in nanoseconds), 
which will represent the maximal clock error on each given PHC timestamp.
The error bound is calculated by the device,  taking into account the accuracy and delays of all the device's PHC components.

Based on our search, there is no similar functionality in other drivers, meaning there is no user interface to expose it.
We're currently exploring the best method of exposing this capability to the user.
Our debate is between:
- Extending the gettimex64 API in ptp_clock_info
- Introducing a new devlink entry
- Updating the time-related ethtool option (-T flag).

As our device sends each PHC timestamp with an error_bound value together, gettimex64 is the reasonable option for us and our recommended solution.
We would like to ask for your recommendation.

We have already consulted with Jakub, who recommended that we consult with all of you.

For more information, you may visit: https://aws.amazon.com/blogs/compute/its-about-time-microsecond-accurate-clocks-on-amazon-ec2-instances/

Thanks,
Amit